Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream parameter in public strings combine APIs #14281

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Expose stream parameter in public strings combine APIs #14281

merged 4 commits into from
Oct 23, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs:

  • cudf::strings::concatenate() (x2)
  • cudf::strings::join_strings()
  • cudf::strings::join_list_elements() (x2)
  • cudf::strings::repeat_string()
  • cudf::strings::repeat_strings() (x2)

Also added stream gtests and fixed up some doxygen comments.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 13, 2023
@davidwendt davidwendt self-assigned this Oct 13, 2023
@github-actions github-actions bot added the CMake CMake build issue label Oct 13, 2023
@davidwendt davidwendt mentioned this pull request Oct 17, 2023
Open
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 23, 2023
@davidwendt davidwendt marked this pull request as ready for review October 23, 2023 14:06
@davidwendt davidwendt requested a review from a team as a code owner October 23, 2023 14:06
hyperbolic2346
hyperbolic2346 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit

cpp/include/cudf/strings/combine.hpp Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e8cf0eb into rapidsai:branch-23.12 Oct 23, 2023
57 checks passed
@davidwendt davidwendt deleted the stream-strings-combine branch October 23, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @hyperbolic2346 @ttnghia