Use f-strings on constants for better readability #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresayac
approved these changes
Oct 2, 2024
alxpez
approved these changes
Oct 7, 2024
|
Please fix CI by create a base URL constant and using that for both voice list and websocket URL. This way you won't hit the maximum characters/line limit. |
rany2
requested changes
Oct 7, 2024
Co-authored-by: Rany <[email protected]>
Co-authored-by: Rany <[email protected]>
Signed-off-by: rany <[email protected]>
rany2
approved these changes
Oct 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a very significant change, but I think it makes it easier to read/modify the url more easily