Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and cleanup #124

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Simplify and cleanup #124

merged 6 commits into from
Oct 10, 2023

Conversation

kennethmorton
Copy link
Contributor

Fix for #123 as well as some general clean up.

@maximusunc
Copy link
Contributor

I've looked over the diff again and I'm unsure where the fix is outside of the general code cleanup. @kennethmorton could you point this out please?

@maximusunc maximusunc marked this pull request as ready for review October 6, 2023 14:27
Copy link
Contributor

@maximusunc maximusunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this with the two robokop queries from the linked issue. The scores are much much better. There are minute discrepancies to the order of 10^-15, which could be accounted for when we go into log space and back out.

Copy link
Contributor

@uhbrar uhbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at it, we already run the sigmoid on property values before calculating the edge_weights, so taking the max is fine. I think this pull request is now ready to go.

@maximusunc maximusunc merged commit 2b77863 into master Oct 10, 2023
1 check failed
@maximusunc maximusunc deleted the simplify_and_cleanup branch October 10, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants