-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and cleanup #124
Simplify and cleanup #124
Conversation
I've looked over the diff again and I'm unsure where the fix is outside of the general code cleanup. @kennethmorton could you point this out please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this with the two robokop queries from the linked issue. The scores are much much better. There are minute discrepancies to the order of 10^-15, which could be accounted for when we go into log space and back out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at it, we already run the sigmoid on property values before calculating the edge_weights, so taking the max is fine. I think this pull request is now ready to go.
Fix for #123 as well as some general clean up.