Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect default language setting #977

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

mikasackermn
Copy link
Collaborator

@mikasackermn mikasackermn commented Dec 30, 2024

Summary

The default language in the settings is set to "Afrikaans" instead of "English".

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@@ -47,7 +47,8 @@ export function General() {
useConfigStore.use.config().theme?.secondaryBorderRadius;
const fontFamily =
useConfigStore.use.config().theme?.fontFamily || DEFAULT_FONT;
const language = useConfigStore.use.config().language || LANGUAGES[0].value;
const enLanguage = LANGUAGES.find((lng) => lng.value === 'en');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't harcode values. you can do this instead to keep one source of truth for langs:
in widget/playground/src/constants/languages.ts

const DEFAULT_LANGUAGE = 'en'
 
// upate the array as well to use this

and export and use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants