Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix hub bugs with wallet list #973

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

RyukTheCoder
Copy link
Collaborator

@RyukTheCoder RyukTheCoder commented Dec 28, 2024

Summary

  1. When hub attempts to auto connect some wallets which are removed from widget config, it results in crashing the app. This problem is resolved in this PR by checking wallets config before performing auto connect.
  2. If list of wallets is given as config to widget which includes a wallet with version "1", it fails to pick both versions for that provider and results in app crash. This problem is fixed in the second commit.

Fixes # (issue)

How did you test this change?

  1. Tested by connecting a wallet which supports auto connect and then remove that wallet from wallets config and refreshing the page. By doing this no crash should happen.
  2. Tested by including 'phantom' in widget config wallets.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

widget/embedded/src/utils/providers.ts Show resolved Hide resolved
widget/embedded/src/utils/providers.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants