Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move namespaces info to provider and remove the hardcoded mapping in wallets-shared #969

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

yeager-eren
Copy link
Collaborator

@yeager-eren yeager-eren commented Dec 15, 2024

Summary

Adds namespace info into providers.

Overtime we needed to have another abstraction called Namespace. In legacy, we haven't support for namespace directly and added it for Ledger and Trezor in some kind of hacky way. One of these hacks were adding a map between some fields in WalletInfo and generate a list for namespaces in Namespace modal.

In this PR, I introduced two new fields called needsNamespace and needsDerivationPath for WalletInfo. Providers now can define the list we show in Namespace by themselves.

Fixes RF-1935

How did you test this change?

It shouldn't affect the functionality. namespace and derivation path should works as before. Ledger, Trezor and Phantom have support for these functionalities i mentioned.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Collaborator

@mikasackermn mikasackermn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants