-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move namespaces info to provider and remove the hardcoded mapping in wallets-shared #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
changed the base branch from
next
to
chore/change-namespace-enum-to-string
December 15, 2024 11:10
yeager-eren
force-pushed
the
feat/rf-1935-namespace-info
branch
from
December 15, 2024 11:13
692a5c3
to
a6d4c11
Compare
yeager-eren
requested review from
mikasackermn,
Ikari-Shinji-re and
RanGojo
as code owners
December 15, 2024 11:13
Base automatically changed from
chore/change-namespace-enum-to-string
to
next
December 16, 2024 11:28
yeager-eren
force-pushed
the
feat/rf-1935-namespace-info
branch
from
December 23, 2024 07:26
a45da11
to
57e5303
Compare
mikasackermn
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yeager-eren
force-pushed
the
feat/rf-1935-namespace-info
branch
2 times, most recently
from
December 31, 2024 10:00
7b327d7
to
2b17b8f
Compare
yeager-eren
force-pushed
the
feat/rf-1935-namespace-info
branch
from
December 31, 2024 15:00
2b17b8f
to
ee0b396
Compare
…ing in wallets-shared
yeager-eren
force-pushed
the
feat/rf-1935-namespace-info
branch
from
January 1, 2025 09:05
ee0b396
to
63e289a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds namespace info into providers.
Overtime we needed to have another abstraction called Namespace. In legacy, we haven't support for namespace directly and added it for Ledger and Trezor in some kind of hacky way. One of these hacks were adding a map between some fields in
WalletInfo
and generate a list for namespaces inNamespace
modal.In this PR, I introduced two new fields called
needsNamespace
andneedsDerivationPath
forWalletInfo
. Providers now can define the list we show in Namespace by themselves.Fixes RF-1935
How did you test this change?
It shouldn't affect the functionality. namespace and derivation path should works as before. Ledger, Trezor and Phantom have support for these functionalities i mentioned.
Checklist: