Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate coinbase to use hub #956

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat: migrate coinbase to use hub #956

wants to merge 1 commit into from

Conversation

mikasackermn
Copy link
Collaborator

@mikasackermn mikasackermn commented Nov 24, 2024 •
edited
Loading

Summary

Coinbase has been migrated to hub

Fixes # (issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch from b56d4cc to 1201036 Compare November 24, 2024 13:22
@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch from 1201036 to bee4930 Compare November 24, 2024 13:51
@yeager-eren yeager-eren changed the base branch from next to feat/support-for-both-legacy-and-hub November 26, 2024 07:01
@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch from 977069a to 8d39865 Compare November 27, 2024 12:00
@yeager-eren yeager-eren force-pushed the feat/support-for-both-legacy-and-hub branch 2 times, most recently from 27f3bbe to 63f00c5 Compare December 1, 2024 07:36
Base automatically changed from feat/support-for-both-legacy-and-hub to next December 1, 2024 07:53
@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch 2 times, most recently from f528b3e to 7814e49 Compare December 2, 2024 08:47
@RanGojo RanGojo assigned nikaaru and unassigned Ikari-Shinji-re Dec 25, 2024
@RanGojo RanGojo requested review from nikaaru and removed request for RanGojo December 25, 2024 07:11
@RanGojo RanGojo removed the request for review from yeager-eren December 25, 2024 07:12
@RyukTheCoder RyukTheCoder requested review from RyukTheCoder and removed request for nikaaru December 29, 2024 10:06
@RyukTheCoder RyukTheCoder assigned RyukTheCoder and unassigned nikaaru Dec 29, 2024
RyukTheCoder
RyukTheCoder approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch from 7814e49 to 4fe0906 Compare January 1, 2025 09:13
@mikasackermn mikasackermn force-pushed the feat/rf-1862-migrate-coinbase-to-use-hub branch from 4fe0906 to 48bdf1a Compare January 1, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyukTheCoder RyukTheCoder RyukTheCoder approved these changes

Assignees

@RyukTheCoder RyukTheCoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikasackermn @RyukTheCoder @yeager-eren @Ikari-Shinji-re @nikaaru