Responsive Images #124
Open
Responsive Images #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid upstream rate-limiting timeout (504)
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
micmro
commented
Jul 19, 2023
| ...metadata, | ||
| })) | ||
| assets.map(({ value, ...rest }, i) => | ||
| batchDelay(i) |
There was a problem hiding this comment.
batch asset requests to avoid upstream (likely rate-limiting) timeouts.
|
Demo App Preview: https://d11mwnosflssyy.cloudfront.net/ |
Code Coverage ReportCoverage after merging batch-asset-download into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2aa6bfc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
micmro
commented
Jul 19, 2023
| @@ -0,0 +1,5 @@ | |||
| /** Customizable Configuration for the Generator */ | |||
There was a problem hiding this comment.
This config can be reused to configure the generator based on project needs, e.g. as an alternative to special tokens
Comment on lines
+9
to
+10
| "src/", | ||
| "./generator-config.ts" |
Comment on lines
+48
to
+59
| .resize( | ||
| width === 'full' // full res version | ||
| ? undefined | ||
| : { | ||
| // resize to max-size, this might sometimes create duplicates, | ||
| // if the source image is small, but this makes the | ||
| width: width, | ||
| height: width, | ||
| fit: 'inside', | ||
| withoutEnlargement: true, | ||
| } | ||
| ) |
There was a problem hiding this comment.
resize based on config and combine with full-res version
Comment on lines
-78
to
+79
| src={src} | ||
| {...srcToSrcSet(src)} |
There was a problem hiding this comment.
Use helper to auto-generate sourceset
brenzy
previously approved these changes
Jul 20, 2023
brenzy
dismissed
their stale review
Michael was unhappy with something in this commit. Unfortunately I have no recollection of what the issue was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largest resolution
Smaller resolution
Also added batching of asset download to work around rate-limiting issues.