-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema refactor #458
base: main
Are you sure you want to change the base?
Schema refactor #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema is not fully validating what it should.
Wondering if it's worth the effort to refactor the pickups and doors as well and move them into the cc section, so then we could have something like:
Could also be good for plandos. |
I like it. It makes it easier to understand and navigate through a patcher file. It goes hand in hand with some code refactoring. E.g. atm patching pickups is just going through a giant list of pickups, which won't exist anymore. Probably should iterate through each scenario, through each collision camera and then call the appropriate patch functions for all the elements. I guess the pdf in RDV will be more like a rewrite of some parts. But I can't answer if it's worth the/your effort. There was some work done in RDV for doing plandos from the rdvgame. |
This changes the schema so it breaks compatibility with older versions, so a major version bump is necessary.
camera_names_dict
has been moved out of cosmetic options and is now calledcollision_camera_attributes
.reveal_map_on_start
has been moved to cosmetic patches, though this one is still not very relevant currentlyI'm leaving this PR as a draft in case we decide on making other big changes to the schema, or if we possibly do keep compatibility with older versions. I'm open to ideas.