Dread BCTEX export to dds #240
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 76.84% 77.65% +0.81%
==========================================
Files 78 80 +2
Lines 3874 4109 +235
==========================================
+ Hits 2977 3191 +214
- Misses 897 918 +21 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
- added a RawTexture class that can parse all images, arrays, surfaces and mipmaps from Dread .bctex formats - added a DdsExporter class that can convert a RawTexture class into a Direct Draw Surface file (byte matching with SwitchToolbox exports) - added tests to validate the SHA256 of (one of) each used XTX format
steven11sjf
force-pushed
the
bctex-export
branch
from
37c6931 to
669fc93
Compare
| width_blks, height_blks, depth_blks, data, height_mip0, mip0.format.bytes_per_pixel | ||
| ) | ||
| return res | ||
| except Exception: |
There was a problem hiding this comment.
What kind of situations can cause this to fail, and why not just let the exception "leak"?
If it's expected to fail sometimes, then return type must indicate it can be None
There was a problem hiding this comment.
it outputs an ugly Rust exception, and after spending a day trying to get rust interop working I didn't bother figuring out the proper exception wrapper haha. If it fails, it would basically mean invalid data in the texture.
I can go back and fix it, just want to wrap up some stuff on navmesh tonight.
| return Texture2D(mips) | ||
|
|
||
| def _deswizzle(self, width: int, height: int, depth: int, mip0: Mip0Data, heightLog2: int, data: bytes) -> bytes: | ||
| height_mip0 = 1 << max(min(heightLog2, 5), 0) |
|
|
||
| folder.mkdir(parents=True, exist_ok=True) | ||
| if not name: | ||
| name = self.raw.name + ".dds" |
There was a problem hiding this comment.
Can you add a test for this method?
|
|
||
| return Texture2D(mips) | ||
|
|
||
| def _deswizzle(self, width: int, height: int, depth: int, mip0: Mip0Data, heightLog2: int, data: bytes) -> bytes: |
There was a problem hiding this comment.
Please add a docstring
|
|
||
| self.parse() | ||
|
|
||
| def parse(self): |
There was a problem hiding this comment.
Is this method supposed to be called multiple times? If it's just the constructor, make it private.
Notes: