Avoid inlining of the function that returns test data #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/inline-never
branch
from
145f1d9 to
8cdcc78
Compare
This appears to be the root cause of the binary size blowing up. Using `#[inline(never)]`, there is no difference in crate size between `include_str!` and `include_bytes!`. Probably something about the expect in the `include_bytes!` approach disabled inlining, leading to the observed improvement. Actually just disabling inlining is going to work more reliably, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be the root cause of the binary size blowing up. Using
#[inline(never)], there is no difference in crate size betweeninclude_str!andinclude_bytes!. Probably something about the expect in theinclude_bytes!approach disabled inlining, leading to the observed improvement. Actually just disabling inlining is going to work more reliably, however.