Some changes to reduce time taken by the coverage build #5240
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the CLI tests takes approximately 25% of the entire runtime of the coverage CI build, and that is dominated by the xmss_sign_test and speed_pk_tests Change CI to only run the 'slow' CLI tests in the shared build which doesn't have the overhead of coverage collection. Split up the speed pk tests into fast and slow variants; only a few of the public key algorithms (most notably RSA and the hash based signatures) are really that costly. Move a few tests that were categorized as slow, but actually are not, into the regular test sequence. Remove generating safe primes from the random_prime benchmark. This was very slow, there aren't enough samples for it to be a useful performance guide, and at this point the performance of generating a safe prime isn't even interesting since finite field DH is kil.
Owner
Author
|
Ah this has the side effect of running a few more of the CLI tests on Windows and mac and there we seem to have some problems. For Windows I expect it's a line-ending thing. For macOs it appears having the additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the CLI tests takes approximately 25% of the entire runtime of the coverage CI build, and that is dominated by the xmss_sign_test and speed_pk_tests
Change CI to only run the 'slow' CLI tests in the shared build which doesn't have the overhead of coverage collection.
Split up the speed pk tests into fast and slow variants; only a few of the public key algorithms (most notably RSA and the hash based signatures) are really that costly.
Move a few tests that were categorized as slow, but actually are not, into the regular test sequence.
Remove generating safe primes from the random_prime benchmark. This was very slow, there aren't enough samples for it to be a useful performance guide, and at this point the performance of generating a safe prime isn't even interesting since finite field DH is kil.