Refactor: Keccak permutation has to be configured statically #5102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the
constevalconstructor idiom we talked about before to theKeccak_Permutationclass. As a result, it is not possible to instantiate the Keccak-p at runtime anymore, but all configurations have to be statically declared and simply copied at runtime.At this point, I'm not sure that this is really worth it (due to the fairly verbose and duplicated declarations in the Keccak-based algorithm implementations). With the basic refactoring and the integration of the Ascon-based algorithms now merged, I'd suggest to come back to this in isolation. Hence the "draft" status.