-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PAYG instructions to v2.8 #1374
base: main
Are you sure you want to change the base?
Conversation
@jeremy-moffitt Referring to #1354, should we recommend users be on Rancher v2.8.4? Should the v2.7 docs be kept or removed? (https://ranchermanager.docs.rancher.com/v2.7/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration) |
.../version-2.8/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
Regarding 2.7 support, any existing customers running PAYG on 2.7 are still in support and do not have to migrate, so I'm hesitant to remove the 2.7 docs at this point. We could add a note indicating the listings have been updated to 2.8.4 and customers are encouraged to remain current with the listing to get the latest features and security fixes.
|
@LucasSaintarbor anything you need from me or my team on this? We'll be starting the updates to 2.9.1 in a couple weeks so we'll have a new request... for now the 2.8.4 info is current. |
…tplace/cloud-marketplace-payg-integration.md
Hey @jeremy-moffitt, sorry for the late reply. May you review my latest update (393aac0)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content changes look good to me. The verbiage around versions is clear and makes sense. Thanks for making the update!
Please let me know if I need to track down another reviewer from my team. I'm assuming one of the doc writers will perform a review aimed at catching non-content issues. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked at the new Supported Versions blurb as I'm trusting (for now) that the v2.8 pages are a straight copy-paste of v2.7 and have already been reviewed in previous PRs. I edited the new section for brevity and put the v2.8 rec more forward, so it's clear to users what version they should use
...ncher/cloud-marketplace/aws-marketplace-payg-integration/aws-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
...r/cloud-marketplace/azure-marketplace-payg-integration/azure-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
.../version-2.7/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
...ncher/cloud-marketplace/aws-marketplace-payg-integration/aws-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
.../version-2.8/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marty Hernandez Avedon <[email protected]>
…tplace/cloud-marketplace-payg-integration.md Co-authored-by: Marty Hernandez Avedon <[email protected]>
FYI, the AWS Rancher PAYG listings are now up to 2.9.1, with Azure to follow shortly. |
Azure is stuck on 2.8.4 for now, but per my previous comment AWS is updated to 2.9.1... let me know if you need more info for the doc update. thanks! |
Fixes #[issue_number]
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Comments