Added test (virtual cluster creation, with pod) and small kubeconfig refactor #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrichman
changed the title
enrichman
changed the title
enrichman
force-pushed
the
166-test-vcluster-pod
branch
from
503af33 to
3231797
Compare
jp-gouin
approved these changes
Jan 24, 2025
galal-hussein
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
This PR adds a test that creates a virtual cluster, and create a Nginx pod in the virtual cluster.
It adds also a small fix to get the proper host patch version
and a small refactor of the kubeconfig generation, moving the bootstrap GetSecret in the bootstrap package.