Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The page Cluster: Create Harvester crashes when the vgpudevice request fails #13120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The page Cluster: Create Harvester crashes when the vgpudevice request fails #13120

wants to merge 1 commit into from
+3 −2

Conversation

votdev
Copy link
Member

@votdev votdev commented Jan 15, 2025 •
edited
Loading

Summary

Fixes #13119

Occurred changes and/or fixed issues

n/a

Technical notes summary

Relocate the request in the already existing try-catch block.

Areas or cases that should be tested

Create a Harvester guest cluster.

Areas which could experience regressions

n/a

Screenshot/Video

n/a

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@votdev votdev added this to the v2.11.0 milestone Jan 15, 2025
@votdev votdev requested a review from torchiaf January 15, 2025 14:33
@votdev votdev self-assigned this Jan 15, 2025
@votdev votdev requested review from a110605 and aalves08 January 15, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf Awaiting requested review from torchiaf

@a110605 a110605 Awaiting requested review from a110605

@aalves08 aalves08 Awaiting requested review from aalves08

At least 1 approving review is required to merge this pull request.

Assignees

@votdev votdev

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

The page Cluster: Create Harvester prints error to console when the vgpudevice request fails
1 participant
@votdev