Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GKE credential to jenkinsfile #13087

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add GKE credential to jenkinsfile #13087

merged 1 commit into from
Jan 27, 2025

Conversation

IsaSih
Copy link
Contributor

@IsaSih IsaSih commented Jan 14, 2025

Summary

ATTENTION!!
Depends on rancherlabs/corral-packages#71 to be merged in the corral-packages repo

Fixes #rancher/qa-tasks#1641
Supports e2e tests in #12934 by Adding the GKE credentials to the jenkins file

Occurred changes and/or fixed issues

GKE cred was stored in the secrets manager with the jenkins identifier tag for the e2e tests that validate GKE cluster provisioning to be executed in the pipeline that stores cloud credentials

Areas or cases that should be tested

Run all e2e tests via the jenkins pipeline

Areas which could experience regressions

Cluster provisioning tests
Cloud credentials creation tests
Any other tests that rely on authentication with cloud credentials

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IsaSih
Copy link
Contributor Author

IsaSih commented Jan 15, 2025

ATTENTION! Please, don't merge this PR before rancherlabs/corral-packages#71 is merged

Signed-off-by: Isabela Guimaraes <[email protected]>
@izaac izaac self-requested a review January 15, 2025 19:43
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the CI pass and it's good to go :shipit:

@izaac
Copy link
Contributor

izaac commented Jan 15, 2025

ATTENTION! Please, don't merge this PR before rancherlabs/corral-packages#71 is merged

Not an issue, here an env variable is just getting set, I don't think it will impact the corral package

@izaac
Copy link
Contributor

izaac commented Jan 22, 2025

@IsaSih @yonasberhe23 We need to update the multi recurring job too I believe https://github.com/rancher/dashboard/blob/master/cypress/jenkins/Jenkinsfile_multi

Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See multi Jenkins file comment.

Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad @IsaSih those credentials are handled automatically by the pipeline and passed to their executors.

@IsaSih IsaSih merged commit 52cf4ef into master Jan 27, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants