-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE credential to jenkinsfile #13087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ATTENTION! Please, don't merge this PR before rancherlabs/corral-packages#71 is merged |
Signed-off-by: Isabela Guimaraes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the CI pass and it's good to go
Not an issue, here an env variable is just getting set, I don't think it will impact the corral package |
@IsaSih @yonasberhe23 We need to update the multi recurring job too I believe https://github.com/rancher/dashboard/blob/master/cypress/jenkins/Jenkinsfile_multi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See multi Jenkins file comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad @IsaSih those credentials are handled automatically by the pipeline and passed to their executors.
Summary
ATTENTION!!
Depends on rancherlabs/corral-packages#71 to be merged in the corral-packages repo
Fixes #rancher/qa-tasks#1641
Supports e2e tests in #12934 by Adding the GKE credentials to the jenkins file
Occurred changes and/or fixed issues
GKE cred was stored in the secrets manager with the jenkins identifier tag for the e2e tests that validate GKE cluster provisioning to be executed in the pipeline that stores cloud credentials
Areas or cases that should be tested
Run all e2e tests via the jenkins pipeline
Areas which could experience regressions
Cluster provisioning tests
Cloud credentials creation tests
Any other tests that rely on authentication with cloud credentials
Checklist