Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The page Cluster: Create Harvester prints error to console when the vgpudevice request fails #13119

Open
votdev opened this issue Jan 15, 2025 · 1 comment · May be fixed by #13120
Open

The page Cluster: Create Harvester prints error to console when the vgpudevice request fails #13119

votdev opened this issue Jan 15, 2025 · 1 comment · May be fixed by #13120
Assignees
@votdev
Labels
area/extensions area/harvester kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this

Comments

@votdev
Copy link
Member

votdev commented Jan 15, 2025 •
edited
Loading

Setup

  • Rancher version: 2.9.3
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug
When creating a new Harvester guest cluster, the page displays an error message because the request to get the VGPU device fails.

I noticed the bug while testing another issue. The red error page is also only displayed when using the dev server. Nevertheless, the error is present and should be intercepted accordingly.

To Reproduce
Setup a ipxe-examples Harvester cluster with a standalone Rancher instance and link them. Then try to create a Harvester guest cluster.

Result

Expected Result
There should be no error message.

Screenshots
Image
Image

Additional context
n/a
@votdev votdev self-assigned this Jan 15, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 15, 2025
votdev added a commit to votdev/harvester-dashboard that referenced this issue Jan 15, 2025
@votdev
The page Cluster: Create Harvester crashes when the vgpudevice requ…
0e52568 
…est fails

Related to: rancher#13119

Signed-off-by: Volker Theile <[email protected]>
@votdev votdev linked a pull request Jan 15, 2025 that will close this issue
Open
7 tasks
@richard-cox richard-cox changed the title The page Cluster: Create Harvester crashes when the vgpudevice request fails The page Cluster: Create Harvester prints error to console when the vgpudevice request fails Jan 15, 2025
@richard-cox
Copy link
Member

richard-cox commented Jan 15, 2025 •
edited
Loading

@votdev i've updated the title to reflect production behaviour. In dev this is a modal and can be closed, rather than a crash

Update: Can you update the issue with the functional impact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@votdev votdev

Labels
area/extensions area/harvester kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
No milestone
2 participants
@votdev @richard-cox