[2.11] Avoid permissions errors on Windows #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobby
approved these changes
Oct 18, 2024
HarrisonWAffel
changed the title
This was referenced Nov 15, 2024
jiaqiluo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#46769
This PR updates
GetFilePermissionWarningsto ignore Windows platforms. The current file permission checks are not appropriate for Windows as Go does not handle permission bits in the same way as it does on Linux. For Windows, Go will only use the owner bit, effectively turning600into666. Access Control Lists are the intended means of securing files, and the cli currently sets the ACLs properly, only allowing access to the local system and administrators.