Avoid overwriting entire KubeCredentials block

[idogada-akamai]

As described in rancher/rancher#46997

Whenever we use rancher token to get a token of cluster we're currently on, instead of just verifying the token expiration date and exiting, the CLI, asks for a re-login and clears the KubeCredentials block.

This PR aims to fix that issue

[crobby]

Looks like a fine change.
Can you add a small unit test to cover this?

[idogada-akamai]

Looks like a fine change. Can you add a small unit test to cover this?
@crobby Can you guide me on how to do that?
I found some stuff around the project, but it's not clear to me

[crobby]

Looks like a fine change. Can you add a small unit test to cover this?
@crobby Can you guide me on how to do that?
I found some stuff around the project, but it's not clear to me

The new test would go in kubectl_token_test.go. We would only need to test the cacheCredential function.
It might be a little bit awkward since I think as it's written right now, you may have to have your test write a config file that would serve as a possible existing configuration so that it can be loaded and rewritten by the function. The test would then need to check the contents of that file to make sure it contains/doesn't contain the expected entries.

[bigkevmcd]

I've written a test for this fix here 78c6a7c feel free to copy the test and update the PR, or we can merge it.

[idogada-akamai]

I've written a test for this fix here 78c6a7c feel free to copy the test and update the PR, or we can merge it.

@bigkevmcd Thank you! I have added the test.

@crobby Can you please review the change and let us know if any further change is required?

[crobby]

I've written a test for this fix here 78c6a7c feel free to copy the test and update the PR, or we can merge it.

@bigkevmcd Thank you! I have added the test.

@crobby Can you please review the change and let us know if any further change is required?

Will do.
Thank you.

It looks like the linter has identified a few issues. You should be able to see the logs and adjust based on that.

[idogada-akamai]

@crobby
Fixed the linting error

[idogada-akamai]

@enrichman I re-used the context for the test

updates made

[idogada-akamai]

@crobby @enrichman
What are our next steps to getting this pushed?

[crobby]

@crobby @enrichman What are our next steps to getting this pushed?

Hopefully, we can get reviewed and merged "soon". I'm not sure which Rancher release will receive this change yet.

[nickvth]

Releasing this change, would make me happy 😃 So any ideas when?