Automatically open browser when getting token#296
Closed
tjcain wants to merge 1 commit intorancher:masterfrom
Closed
Automatically open browser when getting token#296tjcain wants to merge 1 commit intorancher:masterfrom
tjcain wants to merge 1 commit intorancher:masterfrom
Conversation
|
Hey @tjcain I was wondering if this PR was supposed to make the CLI work with Azure AD since it's using OIDC... Currently, latest version of the CLI throws an error when trying to use the AAD provider: I don't think this PR brings a fix to that - what OIDC provider did you have in mind? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small QOL improvement which automatically opens the browser during
rancher tokenif an oidc provider is selected.