Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect boolean parameter ylabel (disable when False) #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexcalligraphy
Copy link

@alexcalligraphy alexcalligraphy commented Jan 17, 2024

Currently, the parameter =ylabel= is ignored and the hard-coded ylable is written regardless of the =ylabel= parameter is truthy or falsy.

This change will not set an ylable for the chart if the =ylabel= parameter is set to a falsy value.

In a next step one could check if =ylable= is a String and if so, set the actual ylable string to that string.

Currently, the parameter =ylabel= is ignored and the hard-coded ylable is
written regardless of the =ylable= parameter is truthy or falsy.

This change will not set an ylable for the chart if the =ylable= parameter is
set to a falsy value.

In a next step one could check if =ylable= is a String and if so, set the actual
ylable string to that string.
@grzesir
Copy link

grzesir commented Jan 31, 2024

Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi

Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants