Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #233
In a recent HOI4 patch (patch 1.17, save_version=30) they deviated from the established binary format norms. The usual F32 token now signals F64 data. Currently the code is tied to associating 0x000d with 32 bits of data.
This PR plays around with allowing each game to define a stateful parser to handle how HOI4, CK3, and EU5 may differ in how something is decoded.
I created a
reader-ngbenchmark that shows an example implementation withMyFormat. I found it to be 10-20% slower thanreader-token-kind, which is not ideal.