Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 05 26 pointers gen #240

Merged
merged 18 commits into from
May 27, 2024
Merged

2024 05 26 pointers gen #240

merged 18 commits into from
May 27, 2024

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented May 26, 2024

Motivation

We are getting to the point that manually managing pointers is unscaleable.

For example rainlanguage/rain.uniswap#21 if we want this to have per-network words there are going to be a lot of pointers to maintain.

Solution

Write a script that generates all the pointers needed for the whole repo. It can include related constants such as bytecode hashes etc.

Scope

This only covers the core contracts, followups

Test

https://github.com/rainlanguage/rain.interpreter/actions/runs/9250431782/job/25443936638 should fail due to the codegen building something different to what is currently committed to the repo.

The pointers and hashes themselves are already covered by existing tests.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs

@thedavidmeister thedavidmeister merged commit 58fddba into main May 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants