Analytics #1777
Analytics #1777
Conversation
| // we are tracking 'Insufficient funds' 'Out of gas' 'No routes found' and 'No quotes found' | ||
| if (!quote || !inputAsset || !outputAsset || !inputAmount) return; | ||
|
|
||
| if ( |
There was a problem hiding this comment.
what is the point of the lastParams logic
There was a problem hiding this comment.
to not send repeated events, like if nothing changed but it triggered a refetch or something, it's the exact same code as the app
| return false; | ||
| }, | ||
| exact: false, | ||
| })[0]; |
There was a problem hiding this comment.
i think this is dangerous, what if the result of getQueriesData is undefined or []?
There was a problem hiding this comment.
react-query should always return an array, [] is desired
There was a problem hiding this comment.
but you can't get the 0 index of an empty array
There was a problem hiding this comment.
it's undefined
| chainId, | ||
| time, | ||
| }: PriceChartQueryKeyArgs) { | ||
| return queryClient.getQueriesData({ |
There was a problem hiding this comment.
if you pass a type parameter here like getQueriesData<QueryKeyType>() you won't need to do the type assertion on line 169
There was a problem hiding this comment.
the generic types the data, not the key
There was a problem hiding this comment.
you might be able to specify the key type like getQueriesData<unknown, Error, unknown, PriceChartQueryKey>()
|
@derHowie Need 1 more review here when you get a chance |
Fixes BX-1709 BX-1708 BX-1712
Figma link (if any):
What changed (plus any additional context for devs)
same as rainbow-me/rainbow#6287
Screen recordings / screenshots
What to test