Validate DB connection pool before starting supervisor #457
+67
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, refactor a bit configuration validation to use ActiveModel's validations.
|
Neat idea to use Active Model |
|
Just wanted to drop a note in case others run into the same issue I did with this change. For those running Kamal deployments and using the RAILS_MAX_THREADS as the pool size, the job runner process will fail to start but Kamal thinks it's a good deployment because the web process starts fine. The jobs docker container will be stuck in an infinite restart loop until the pool size is appropriately configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #427 to also fail when the DB connection pool is too small.