Specify source of SolidQueue to ErrorReporter
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the default value `application.active_support` is applied for source. This does not identify it as an exception raised inside SolidQueue. > source: a String about the source of the error. The default source is "application". Errors reported by internal libraries may set other sources; the Redis cache library may use "redis_cache_store.active_support", for instance. Your subscriber can use the source to ignore errors you aren't interested in. This is a quote from the [rails guide](https://github.com/rails/rails/blob/v8.0.0/guides/source/error_reporting.md?plain=1#L216-L220). Follow this guide to specify the source so that it can be determined that the error originated from inside SolidQueue. Fixes rails#446
tmimura39
commented
Dec 9, 2024
| @@ -4,7 +4,7 @@ module SolidQueue | |||
| module AppExecutor | |||
| def wrap_in_app_executor(&block) | |||
| if SolidQueue.app_executor | |||
| SolidQueue.app_executor.wrap(&block) | |||
| SolidQueue.app_executor.wrap(source: "application.solid_queue", &block) | |||
There was a problem hiding this comment.
application.solid_queue
Not sure if these values are the best🙃
I followed the naming rules described here.
There was a problem hiding this comment.
That seems reasonable to me, reading that comment there 🤔
|
This is great, thank you so much @tmimura39! 🙇♀️ 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default value
application.active_supportis applied for source. This does not identify it as an exception raised inside SolidQueue.This is a quote from the rails guide.
Follow this guide to specify the source so that it can be determined that the error originated from inside SolidQueue.
Fixes #446