New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to pass MYSQL_PREPARED_STATEMENTS to container #128

Merged

kamipo merged 1 commit into rails:main from zzak:env-mysql_prepared_statements

Nov 22, 2024

+1 −0

Member

zzak commented Nov 21, 2024 •

edited

Loading

We have to explicitly allow any environment variables we want to pass through to the container.

How to test

cd ~/code/rails
gh pr checkout 53697
rsync -av --progress /home/zzak/code/buildkite-config/ .buildkite
RUBY_IMAGE="ruby:3.3" docker compose -f .buildkite/docker-compose.yml build base

MYSQL_PREPARED_STATEMENTS=true IMAGE_NAME="buildkite-base" RUBY_IMAGE="ruby:3.3" docker compose -f .buildkite/docker-compose.yml run mysqldb runner activerecord 'rake mysql2:test'

Also tested without the env var.


          Make sure to pass MYSQL_PREPARED_STATEMENTS to container

07e62fb

zzak mentioned this pull request

Log that prepared_statements enabled for mysql2 rails/rails#53697

Open

kamipo merged commit 2910727 into rails:main

1 check was pending

zzak deleted the env-mysql_prepared_statements branch

November 22, 2024 07:02

zzak mentioned this pull request

Fix prepared statements on mysql2 adapter rails/rails#53702

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet