Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref callbacks can now return cleanup functions in React 19. Currently it's not always possible to use the new cleanup-returning ref callbacks with Radix components. For instance, the following example with
TextField
from Radix Themes isn't working properly.Instead of logging
removed
when unmounting, this logscreated null
.This PR fixes the issue. I added a single test for the
Switch
component to test the behaviour.I also updated the main workspace React version to 19 and fixed a handful of type-checking issues. However, all packages should still be compatible with earlier React versions.
Storybook also needed an update, as the previous version was not compatible with React 19. I performed the update by simply running their codemod.