Fixed "Collapsible: --radix-collapsible-content-height CSS variable m… #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing when equal to 0"
neo-schobert
requested review from
StephenHaney,
lucasmotta,
hadihallak and
chaance
as code owners
|
Fixed #3037 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a bug where the --radix-collapsible-content-height CSS variable is not set when the Collapsible content's height equals zero. This issue caused incorrect behavior in nested collapsible components, as they would inherit the variable from their parent, leading to unexpected animations.
Problem
When a Collapsible content node has no height (e.g., empty content), the --radix-collapsible-content-height variable is missing. In a nested collapsible structure, child nodes without content inherit the variable from their parent, resulting in incorrect animations or unexpected visual behavior.
Solution
This PR ensures that the --radix-collapsible-content-height CSS variable is always defined on the content node, even when the height is zero. Specifically:
When the height of a Collapsible content is zero, the variable is explicitly set to --radix-collapsible-content-height: 0.
Changes
Updated logic to always define the --radix-collapsible-content-height variable on collapsible content, regardless of its height.
Added tests to verify that the variable is correctly applied when content height is zero.
Included an update to the documentation for developers to clarify the behavior of --radix-collapsible-content-height in nested structures.