-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds React 19 RC and React-DOM 19 RC to the list of peer dependencies #2952
Conversation
Thanks @BenAHammond, could you go throw "Tracking version changes" step mentioned in the release process and note each primitive package change as a patch? We'll be able to merge the PR then. |
Interestingly those instructions aren't working for me. I see files generated:
but there's nothing to add in git? I'm guessing this is a
|
Not sure, out gitignore is set up to not ignore |
Thank you! |
What about @radix-ui/react-icons? |
Yes I am in the same boat as @kamami . Currently upgrading project to Nextjs 15 with React 19 and getting this issue. |
same |
Same here, any idea on how to upgrade to next 15 that depends on react 19 ? Can't end the update with this package @radix-ui/react-icons |
React 19 help |
I'm going to pile on here. There were no problems in the canary releases of Next 15 but as soon as updating to 15.0.1 the following starts to appear (this is with SelectPrimative.Icon but shows with other components too). Functionally things still work but it's a typescript mess.
I'll mention that I'm using these via Shadcn and there are uses of "ref" in there that are problematic but it looks like there are problems in the primitives too. |
Any update to the @radix-ui/react-icons? |
help |
Description