fix: [@radix-ui/react-tooltip] tooltip performance issue #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this in? @benoitgrelard @andy-hook @tangye1234 is there a way I can prevent this from happening at the caller? Seems to be internal inaccessible state, but figured I'd ask. |
chaance
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
chaance
added
Priority: High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this pr is to resolve the performance issue of tooltip provider.
When there are lots of tooltips inside tooltip provider, everytime tooltip open state is changing, all of the tooltips will re-render regardless of its relation to the iteraction.
I found that provider only provides some context settings and also help to maintain some lifecycle states, while tooltip itself is enough to control its own open state. So I think it is unneccessary for the provider's states to be broadcasted to all context consumers.