fix: Select should not crash if getItems returns empty array

[benj-dobs]

Description

• Fixes [Select]: sometimes, brief flash of no items (resulting in undefined ref on initial render at top of viewport) #1795 (confirmed to fix reproduction at [Select]: sometimes, brief flash of no items (resulting in undefined ref on initial render at top of viewport) #1795 (comment))
• Fixes [Select] ref to collection is undefined #2535

I have not added tests because I couldn't make the simple reproduction case from #2535 work in the test environment. I could reproduce it in Storybook, but this seemed like an odd thing to add to Storybook, so I didn't.

It's possible this solution is incomplete, but it fixes both of the above reproductions, so it's probably good enough for now.

[maxired]

Hi. I am facing a similar crash on a use case similar to the one of #2535
I think that this fix make sens

[izhan]

Our customers hit this error every single day. Is it possible to get this merged? Also happy to help out with this PR if it needs changes

[benj-dobs]

In case anyone else is wondering about how maintainer activity seems to have just died without a word, there are some signs of life on the Discord:

https://discord.com/channels/752614004387610674/803656831704629298/1199950373650190336

No idea when this issue will get fixed but for now using patch-package or yarn resolutions is probably your best workaround.

[tomtomprince]

We're also facing this issue. Going the patch-package route for now but it'd be great to merge this in

[chaance]

Hey all! I'm back on the team and will be reviewing some old PRs, cleaning up the backlog in the coming weeks. This one's first on the list. Thanks for hanging with us 🙏

[tatwater]

Hey @chaance for some reason this fix got undone in a more recent version 😢 Facing this issue again now that we're on v2.1.1 and the inspector shows that the source code has reverted to not checking that items has length before indexing into it

[blackbird-chrisf]

@tatwater I'm encountering a bug here too, I don't think this change actually made it out with 2.1.1 but I can see it in the latest 2.1.2 release candidate: https://www.npmjs.com/package/@radix-ui/react-select/v/2.1.2-rc.8?activeTab=code

[tatwater]

@blackbird-chrisf Oop I meant to amend my comment last month; I reached out on Discord and heard basically exactly what you discovered from Chance himself! Sorry for leaving it so a month later you still had to dig for that. Looking forward to 2.1.2!

[chaance]

For all those following: this has shipped in v2.1.2