Minor changes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHeath
reviewed
Feb 20, 2020
src/Anon.ts
Outdated
| @@ -34,6 +34,7 @@ export default function anonymize(dict) { | |||
| for(const key of Object.keys(dict)) { | |||
| // Use default action or action specified in policy | |||
| var rule = policy["default"]; | |||
| //what happens if key is not in policy? ??? | |||
There was a problem hiding this comment.
rule is initially set to the default policy (the preceding line).
If there's a policy for that specific key, we use that instead.
DanielHeath
reviewed
Feb 20, 2020
src/Anon.ts
Outdated
| // TODO: Test that there's no personal data stored outside the "Value" for a | ||
| // given tag. This should be the case, and we're making the assumption that the | ||
| // user is not maliciously trying to hide data. | ||
| export default function anonymize(dict) { | ||
| var newDict = {}; | ||
| for(const key of Object.keys(dict)) { | ||
| // Use default action or action specified in policy | ||
| //CONSIDER MOVING NEXT LINE OUTSIDE THE LOOP! (CMHM) |
There was a problem hiding this comment.
We need to reset rule to the default policy for each loop iteration - otherwise, the policy rule for the previous field would be used if none were defined.
DanielHeath
reviewed
Feb 20, 2020
| // OBVIOUSLY I NEED TO CHECK that CT and MRI are not hashed or encoded or entered as Numbers or , or or,or | ||
| // // "00080016": {"action":"keep", "description":"SOP Class UID"}, | ||
| // The following are additional fields to check: | ||
| // "00080060": { "description":"Modality"}, |
There was a problem hiding this comment.
This is listed in the default set of policies at https://github.com/radiopaedia/dicomanon/blob/master/src/DefaultPolicy.ts#L9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a colon, noting something that could be pulled out of a loop (i moved it because it's computationally expensive!), and describing my plan