Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prettier-json-stringify formatter #183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielpza
Copy link
Contributor

Adds a new formatter for prettier prettier-json-stringify which uses prettier json-stringify parser. json-stringify parser is used by prettier for formatting package.json files

@danielpza danielpza marked this pull request as ready for review March 30, 2023 15:40
@danielpza
Copy link
Contributor Author

I used these changes together with #150 (comment) to make apheleia correctly format package.json files

Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mind adding a test?

@danielpza danielpza force-pushed the prettier-json-stringify branch from 40c7ff1 to 980adde Compare December 25, 2024 23:52
@danielpza danielpza force-pushed the prettier-json-stringify branch from 980adde to c158010 Compare December 26, 2024 00:06
@danielpza
Copy link
Contributor Author

Looks good, mind adding a test?

@raxod502, added some tests, thanks for the patience

@danielpza
Copy link
Contributor Author

danielpza commented Dec 26, 2024

@raxod502 is it possible to make this the default formatter in apheleia for "package.json" files, but not all json files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants