migrate RadarUtils to swift #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge conflict is the sdk version update, will update it after review since there may be more version updates while this is still in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a slow but swift migration
...
swift and objective-c is fully inter-op-able, the migration only requires converting the
*.mfile into a*.swiftfile.If there are no other objective-c implementations that requires a swift class (i.e. all the references of a swift class are other swift classes), then the
*.hfile can be omitted, and the @objc tags can be removed, this is for internal interfaces only.For public interfaces, the swift class can be marked
publicand then*.hheader is not required if there are no more references in other headers.shoutout to chatGPT for helping to convert the objective-C file into swift without too much pain.
something to note:
UIApplication.shared.backgroundTimeRemainingwhen invalid returns1.79769e+308in swift,infin obj-c. This value is only used as part of logging.I've also tested building this branch with waypoint, and it's working properly.