Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NSURLComponent to build query strings #376

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ShiCheng-Lu
Copy link
Contributor

@ShiCheng-Lu ShiCheng-Lu commented Aug 6, 2024

properly escape each query param instead of escaping the entire url string at the end. uses NSURLComponent and NSQueryItem.

Tested with example app and made sure all the requests are returning the same as before.

@ShiCheng-Lu ShiCheng-Lu requested a review from lmeier August 6, 2024 16:58
@@ -22,6 +22,7 @@ typedef void (^_Nullable RadarAPICompletionHandler)(RadarStatus status, NSDictio
sleep:(BOOL)sleep
logPayload:(BOOL)logPayload
extendedTimeout:(BOOL)extendedTimeout
verified:(BOOL)verified
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved verified into API helper to match android.

…-search-geofences-not-working-correctly-with-metadata-filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant