Gabrielalao/fence 1339 upgrade flutter sdk to latest ios and android radar sdk #34
Conversation
gabrielalao
requested review from
nickpatrick and
tjulien
and removed request for
nickpatrick
| @@ -208,9 +198,6 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull final Result result) | |||
| case "setAnonymousTrackingEnabled": | |||
| setAnonymousTrackingEnabled(call, result); | |||
| break; | |||
| case "setAdIdEnabled": | |||
There was a problem hiding this comment.
For breaking changes, we add entries to MIGRATION.MD. This repo doesn't have one yet, but let's create one. It should be formatted like this: https://github.com/radarlabs/radar-sdk-ios/blob/master/MIGRATION.md
There was a problem hiding this comment.
We can put all of the renamed functions in there as well, like that latest ios MIGRATION files does
| JSONObject obj = new JSONObject(); | ||
| obj.put("status", status.toString()); | ||
| if (address != null) { | ||
| //obj.put("address", address.toJson()); |
There was a problem hiding this comment.
Let's uncomment this and we'll fix the NaN bug in the radar android SDK
pubspec.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: flutter_radar | |||
| description: Flutter package for Radar, the leading geofencing and location tracking platform | |||
| version: 3.1.7 | |||
| version: 3.1.8 | |||
CHANGELOG.md
Outdated
| @@ -1,3 +1,18 @@ | |||
| # 3.1.8 | |||
| @@ -10,7 +10,7 @@ Pod::Spec.new do |s| | |||
| s.source_files = 'Classes/**/*' | |||
| s.public_header_files = 'Classes/**/*.h' | |||
| s.dependency 'Flutter' | |||
| s.dependency 'RadarSDK', '3.5.9' | |||
| s.dependency 'RadarSDK', '3.8.9' | |||
There was a problem hiding this comment.
above, let's update s.version to 3.2
|
@tjulien fixed all please review again |
|
Looks good - except |
|
@tjulien I updated migration.md I thought I pushed the commit. |
| - `Radar.setAdIdEnabled()` has been removed. | ||
| - Custom events have been renamed to conversions. | ||
| - `Radar.sendEvent(customType, location, metadata)` is now `Radar.logConversion(name, revenue, metadata)`. | ||
| - The method response does not include `location` and `user` props anymore. |
There was a problem hiding this comment.
Can you add code snippets below of the migration, for example, how this is done in the native SDKs: https://github.com/radarlabs/radar-sdk-android/blob/master/MIGRATION.md#36x-to-370
There was a problem hiding this comment.
@tjulien added code snippets
setAdIdEnabledsendEventtologConversionand addrevenueparamtrackVerifiedtrackVerifiedTokenisUsingRemoteTrackingOptionsautocompleteQuerywith param addexpandUnitsvalidateAddressApp Attestto ios examplePlay Integrity APIto android example