move types out to separate file so it can be shared with react-native… #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for better consistency
… backward compatibility
ShiCheng-Lu
commented
Aug 6, 2024
| @@ -39,7 +39,7 @@ jobs: | |||
| - run: cd example && npm install | |||
| - run: cd example && ionic build | |||
| - run: cd example && npx cap sync | |||
| - run: cd example && ionic capacitor run ios --target $(ionic capacitor run ios --list | grep -o -m 1 '[A-F0-9]\{8\}-[A-F0-9]\{4\}-[A-F0-9]\{4\}-[A-F0-9]\{4\}-[A-F0-9]\{12\}') | |||
| - run: cd example && ionic capacitor run ios --target $(ionic capacitor run ios --list | grep 'iPhone' | grep -o -m 1 '[A-F0-9]\{8\}-[A-F0-9]\{4\}-[A-F0-9]\{4\}-[A-F0-9]\{4\}-[A-F0-9]\{12\}') | |||
There was a problem hiding this comment.
make sure target is an iPhone, it wasn't working possibly due to it selected apple vision pro as the device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for better consistency
! This has some breaking changes in the form of type renames to be consistent with react-native. Most signatures stayed the same with only the type name changing.
I think only trackVerified changed significantly, but that's due to the signature change from iOS/Android a while ago, the previous version had the wrong type.