feat: Refactor mech driver #500
Conversation
| if method == "delete": | ||
| resp_data = {"status_code": resp.status_code} | ||
| else: | ||
| resp_data = resp.json() |
There was a problem hiding this comment.
What's special about DELETE?
| if method == "delete": | |
| resp_data = {"status_code": resp.status_code} | |
| else: | |
| resp_data = resp.json() | |
| if resp.content: | |
| resp_data = resp.json() | |
| else: | |
| resp_data = {"status_code": resp.status_code} |
| def make_api_request(self, url: str, method: str, payload: dict) -> dict: | ||
| endpoint_url = urljoin(self.base_url, url) | ||
| caller_function = inspect.stack()[self.CALLER_FRAME].function | ||
| api_call = getattr(self.s, method) |
There was a problem hiding this comment.
Consider just using self.s.request(method, url, ...) although I think that requires method to be upper case.
https://requests.readthedocs.io/en/latest/api/#requests.Session.request
| args = {"url": endpoint_url, "timeout": 10} | ||
|
|
||
| if method != "get": | ||
| args["payload"] = payload |
There was a problem hiding this comment.
Requests library calls this param data. How is this working?
| if network_id == cfg.CONF.ml2_type_understack.provisioning_network: | ||
| network_name = "provisioning" | ||
| port_status = "Provisioning-Interface" |
There was a problem hiding this comment.
So this sets the port status to Provisioning, doesn't it have to set it back again afterwards?
| "Sleeps 5 seconds between attempts.", | ||
| ), | ||
| cfg.BoolOpt("argo_dry_run", default=True, help="Call Undersync with dry-run mode"), | ||
| cfg.BoolOpt("argo_force", default=False, help="Call Undersync with force mode"), |
There was a problem hiding this comment.
I added these options to the undersync API because they might be useful for troubleshooting, etc., but I don't think they need to be exposed here unless we have a specific need for them. I can maybe see a reason to have dry_run but certainly "force" would not be a good thing to have permanently switched on.
mfencik
force-pushed
the
refactor_mech_driver
branch
from
1c54661
to
e31fbc9
Compare
After this is tested and merged, I'm aware we can do a better cleanup in workflows as we won't need undersync_device workflow anymore.
This PR needs another change in Nautobot prep_switch_interface job as from now on we can use connected_interface_uuid instead of mac_address, so please leave merging to me.