Add file for strong naming assembly #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably will have to be a |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 93.01% 93.05% +0.03%
==========================================
Files 107 104 -3
Lines 9204 9139 -65
Branches 724 722 -2
==========================================
- Hits 8561 8504 -57
+ Misses 496 489 -7
+ Partials 147 146 -1 ☔ View full report in Codecov by Sentry. |
|
Building from this PR and running the same command yields: Does it mean it has strong assembly? 🙈 |
|
You know I could actually have tested that 🤦 |
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
1008cdd to
c974960
Compare
|
Hmm the tests run fine in my Ubuntu / WSL environment, I don't see this error: I'll figure it out. It has to do with the |
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
6daa77e to
5735010
Compare
|
I get a public key token now: Should be good to go when CI passes 👍 |
Zerpet
previously approved these changes
May 10, 2023
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
5735010 to
a61acaf
Compare
Zerpet
previously approved these changes
May 11, 2023
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
3ff004d to
51c3a8c
Compare
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
51c3a8c to
20f34cd
Compare
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
3 times, most recently
from
d419b97 to
de82880
Compare
If you use `sn -T` on the version 1.3.0 RabbitMQ dll, you get this: ``` lib\net6.0> sn -T .\RabbitMQ.Stream.Client.dll Microsoft (R) .NET Framework Strong Name Utility Version 4.0.30319.0 Copyright (c) Microsoft Corporation. All rights reserved. .\RabbitMQ.Stream.Client.dll does not represent a strongly named assembly ``` Actually do the signing correctly. Thanks for double-checking @Zerpet Add `AltCoverStrongNameKey` to fix builds using AltCover
lukebakken
force-pushed
the
lukebakken/add-strong-name-file
branch
from
de82880 to
9620905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
sn -Ton the version 1.3.0 RabbitMQ dll, you get this: