-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up documentation, configuration, and CI following S2 version update #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
configure
script to remove pathways that are no longer supported. Basically,pkg-config
is required now (because resolving the linking order of theabsl
static libraries is absolutely insane without it). It also improves the error messages for various types of failures, although probably not all of them.docker compose
setup to ensure that the compile + test works based on the install instructions for various linux setups. Notably, it makes sure that it effectively uses system Abseil where available (e.g., debian testing, fedora >= 39, alpine), and that it does not use system Abseil of an insufficient version (e.g., all current Ubuntu, Fedora 36).This PR does not fix R 4.0 and R 4.1 on Windows yet (battle for another day).