Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "headtails" vignette #26

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Add "headtails" vignette #26

merged 3 commits into from
Mar 27, 2020

Conversation

dieghernan
Copy link
Contributor

Fix #20 This PR adds a vignette to the package. I used knitr, and also rmarkdown has been added. The configuration was done by usethis::use_vignette() (https://usethis.r-lib.org/reference/use_vignette.html, @hadley).

Please let me know if this work matches your expectations.

A number of checks (not included in the PR) have been performed

Regards

@dieghernan
Copy link
Contributor Author

I forgot to add this,

  • The source package classInt_0.4-3.tar.gz is 136KB on my computer.
  • After installed, total size of the doc/ folder is 256KB

Regards

@rsbivand
Copy link
Member

OK, thanks. Maybe the built size can be moderated by combining images, but this may be handled later when closer to CRAN submission.

@rsbivand rsbivand merged commit d024051 into r-spatial:master Mar 27, 2020
@rsbivand
Copy link
Member

Most of the added bulk is in the JS in the HTML file, I think. This is typical of rmarkdown, I'm afraid. Rendering to PDF with knit is about the same size. Since it is informative, I don't think it is a problem, but thanks for noticing and mentioning this.

@dieghernan
Copy link
Contributor Author

Thank you, regards

@rsbivand
Copy link
Member

rsbivand commented Apr 8, 2020

classInt on CRAN, thanks very much for your contribution! We can refine the vignette later if need be.

@dieghernan
Copy link
Contributor Author

My pleasure, thanks to you for all your contributions to the R community

@rsbivand
Copy link
Member

rsbivand commented Apr 8, 2020

... already deployed in tmap https://github.com/mtennekes/tmap/issues/406#issuecomment-610830460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature: "headtails" method
2 participants