Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support S3 vectors in vars_select() and one_of() #117

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Support S3 vectors in vars_select() and one_of() #117

merged 4 commits into from
Sep 12, 2019

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Sep 11, 2019

Closes #109.

@lionel- lionel- requested a review from hadley September 11, 2019 17:11
hadley
hadley approved these changes Sep 11, 2019
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
R/select-helpers.R Show resolved Hide resolved
@lionel- lionel- merged commit 5fa4541 into r-lib:master Sep 12, 2019
@lionel- lionel- deleted the fix-select-s3 branch September 12, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select() should warn on factor arguments
2 participants
@lionel- @hadley