netezza: boolean column handling (#850)

* netezza: boolean column handling * try dev dbitest * Update NEWS.md Co-authored-by: Simon P. Couch <[email protected]> --------- Co-authored-by: Simon P. Couch <[email protected]>
r-dbi · Sep 30, 2024 · ba7223f · ba7223f
1 parent d4d5ee5
commit ba7223f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.github/workflows/db-windows.yml b/.github/workflows/db-windows.yml
@@ -91,6 +91,16 @@ jobs:
           install.packages(".", repos = NULL, type = "source")
         shell: Rscript {0}
 
+      - name: Install remotes
+        run: |
+          install.packages("remotes")
+        shell: Rscript {0}
+
+      - name: Install dev DBItest
+        run: |
+          remotes::install_github("detule/DBItest@test/stale_send_query")
+        shell: Rscript {0}
+
       - name: Test
         run: |
           options("odbc.interruptible"=TRUE);testthat::test_local(reporter = testthat::ProgressReporter$new(max_failures = Inf, update_interval = Inf))

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # odbc (development version)
 
-* Netezza: Improved data type inference for character columns (#847).
+* Netezza: Improved data type inference for character and boolean
+  columns (#847, #850).
 
 * Added functions `odbcEditDrivers()`, `odbcEditSystemDSN()`, and
   `odbcEditUserDSN()` to provide a shorthand for 

diff --git a/R/driver-netezza.R b/R/driver-netezza.R
@@ -10,6 +10,7 @@ setMethod("odbcDataType", "NetezzaSQL",
     switch_type(
       obj,
       character = varchar(obj),
+      logical = "BOOL",
       callNextMethod(con, obj, ...)
     )
   }