Rework RoomMessageEvent content API again #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's really straightforward now :) RoomMessageEvent::has<>() - check that it's possible to extract event content of a given type; RoomMessageEvent::get<>() - actually try to get event content of that type. At this point has() is not optimised and in some cases effectively creates a content object any way. Can be tackled sometime later.
|
nvrWhere
reviewed
Oct 19, 2024
nvrWhere
reviewed
Oct 19, 2024
We already have fillJson() for FileSourceInfo, adding a deserialising function is just logical (and fixes a problem with Thumbnail's EFM structure never being initialised because EFM had to be supplied as a separate argument and was forgotten).
Instead of deserialising the FileSourceInfo structure from the event, updating it and serialising again, just serialise the new structure and update the content JSON with the result.
Fixes dealing with common attributes being a problem, described in #812 (comment)
kdesysadmin
pushed a commit
to KDE/neochat
that referenced
this pull request
Oct 23, 2024
kdesysadmin
pushed a commit
to KDE/neochat
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really straightforward now :)
RoomMessageEvent::has<>()- check that it's possible to extract event content of a given type;RoomMessageEvent::get<>()- actually try to get event content of that type. At this pointhas()is not optimised and in some cases effectively creates a content object any way. Can be tackled sometime later.