feat: add joinrule api and joinrulesevent #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
joinrulesevent
branch
from
f08e95f
to
b67568f
Compare
KitsuneRal
requested changes
Feb 12, 2023
Comment on lines
+8
to
+16
| class JoinRulesEvent : public StateEvent { | ||
| public: | ||
| QUO_EVENT(JoinRulesEvent, "m.room.join_rules") | ||
|
|
||
| explicit JoinRulesEvent(const QJsonObject& obj) : StateEvent(obj) {} | ||
|
|
||
| QString joinRule() const; | ||
| QJsonArray allow() const; | ||
| }; |
There was a problem hiding this comment.
This is a rather basic implementation of m.room.join_rules, missing the safeguards that I would expect it to have. At the very least, joinRule should be an enum (hopefully we don't get a tide of new join rules in the next year, as we've just added a bunch). Even better, allow could actually be made a vector of AllowCondition structures defined in the spec. I realise this is more work than just copying code from NeoChat - if you don't feel like doing it, let me know and I will help.
Decodetalkers
force-pushed
the
joinrulesevent
branch
from
b67568f
to
3db0272
Compare
|
I'll take this over if you don't mind. |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add joinrule, code from neochat