Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

add tox support to quokka #673

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

marcosptf
Copy link
Collaborator

@marcosptf marcosptf commented Nov 11, 2018

this branch is to add tox support to python36 and python37 pytest env

Att,
@marcosptf

…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 0
@pep8speaks
Copy link

pep8speaks commented Jun 2, 2019

Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-06 08:36:34 UTC

marcosptf added 8 commits June 2, 2019 11:58
…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 1
…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 2
…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 3
…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 4
…odels.py - quokka/core/content/utils.py - quokka/core/content/views.py - quokka/core/db.py - quokka/core/views/sitemap.py - quokka/utils/upload.py - 5
@marcosptf marcosptf changed the title WIP: add tox support to quokka add tox support to quokka Jun 6, 2019
Copy link

@cesarbruschetta cesarbruschetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea for tox so we can test several versions of python ...
I just believe it is good to make a git squash to gather all commits before sending to the master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants