Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new credentials v2 api #352

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat: use new credentials v2 api #352

merged 5 commits into from
Dec 17, 2024

Conversation

infinitewarp
Copy link
Member

See quipucords/quipucords#2744 for details about the new API.

Relates to JIRA: DISCOVERY-797

@infinitewarp infinitewarp marked this pull request as draft October 15, 2024 17:39
@infinitewarp infinitewarp mentioned this pull request Oct 15, 2024
Merged
@infinitewarp infinitewarp force-pushed the credentials-v2 branch 2 times, most recently from 49c11af to d34e945 Compare October 15, 2024 19:41
@infinitewarp infinitewarp marked this pull request as ready for review October 15, 2024 19:46
@infinitewarp infinitewarp requested a review from a team October 15, 2024 19:46
@infinitewarp infinitewarp enabled auto-merge (rebase) October 16, 2024 17:16
@infinitewarp
Copy link
Member Author

I am changing this PR to draft status while we figure out some integration test changes in camayoc.

@infinitewarp infinitewarp marked this pull request as draft October 16, 2024 19:28
auto-merge was automatically disabled October 16, 2024 19:28

Pull request was converted to draft

@mirekdlugosz
Copy link
Contributor

In qpc/cred/{add,edit}.py we should remove --sshkeyfile flag, and possibly most / all references to filename arg variable in qpc/cred/utils.py, qpc/tests/cred/test_cred_add.py and qpc/tests/cred/test_cred_edit.py, possibly other places as well.

ssh_keyfile key in payload is marked as read_only in v2, so it doesn't make sense to send it, and we should not expose it as an available option.

@mirekdlugosz mirekdlugosz mentioned this pull request Dec 5, 2024
Merged
@infinitewarp
feat: use new credentials v2 api
a596ec9 
See quipucords/quipucords#2744 for details about the new API.

Relates to JIRA: DISCOVERY-797
@infinitewarp infinitewarp marked this pull request as ready for review December 16, 2024 20:28
@infinitewarp
docs: remove --sshkeyfile from man pages, clarify that secrets are ne…
6f9df65 
…ver output in responses

Relates to JIRA: DISCOVERY-797
@infinitewarp
Copy link
Member Author

The continuous-integration/jenkins/pr-head check fails because camayoc requires additional changes that correspond with this PR's changes. Mirek ran standalone job 224 with the two new branches, and it completed successfully.

This branch must merge at the same time or very shortly after quipucords/camayoc#554 merges.

@infinitewarp infinitewarp merged commit 27bdce9 into main Dec 17, 2024
14 of 15 checks passed
@infinitewarp infinitewarp deleted the credentials-v2 branch December 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirekdlugosz mirekdlugosz mirekdlugosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinitewarp @mirekdlugosz