Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jinja-cli with local python script #285

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

infinitewarp
Copy link
Member

@infinitewarp infinitewarp commented Oct 24, 2023

Packages for jinja-cli and jinja-cli2 are not available in our downstream build system. Our use case for rendering Jinja template content is very simple, though. So, I wrote this small script to use the jinja2 library directly (which we do have available downstream for both RHEL8 and RHEL9) to replace our single use of the jinja program, and I dropped jinja-cli from our Poetry environment and replaced it with just jinja2.

I deliberately made this a standalone script and not part of the qpc package because we want to run this as a build step downstream, and we don't need to install all of qpc just to generate the man page.

@infinitewarp infinitewarp marked this pull request as draft October 24, 2023 20:02
@infinitewarp infinitewarp force-pushed the jinja-render-script branch 4 times, most recently from 8b02fb3 to 1b509ac Compare October 25, 2023 15:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #285 (eb026ab) into main (4e4dc7a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          67       67           
  Lines        2827     2827           
=======================================
  Hits         2650     2650           
  Misses        177      177           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@infinitewarp infinitewarp marked this pull request as ready for review October 25, 2023 16:01
@infinitewarp infinitewarp requested a review from a team October 26, 2023 20:21
Copy link
Contributor

@bruno-fs bruno-fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infinitewarp infinitewarp merged commit a5d85e9 into main Oct 27, 2023
6 checks passed
@infinitewarp infinitewarp deleted the jinja-render-script branch October 27, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants